Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sequences in HLT Upgrade simplified menu #44523

Merged
merged 3 commits into from
Mar 26, 2024

Conversation

rovere
Copy link
Contributor

@rovere rovere commented Mar 23, 2024

PR description:

This PR optimises the sequence-based HLT Upgrade Phase2 menu. Main ingredients:

  • Remove full Tracking sequence from Muon paths that do not use it
  • Remove hltEcalUncalibRecHit module as a duplicate of ecalMultiFitUncalibRecHit
  • Optimally reorder filters in Egamma Paths by running full tracking at the very end, before the last filter that needs tracks.

PR validation:

Tested using HLT Upgrade Simplified menu.

With these changes, the timing as measured on my development machine went down quite a bit:

before
after

Nota Bene: For the timing measurements above, the Tau paths have been disabled temporarily because they were causing the triggering of full tracking on all events. This will likely be fixed once L1 seeding for Tau paths is introduced.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 23, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44523/39654

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rovere for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@mmusich, @cmsbuild, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@wang0jin, @silviodonato, @thomreis, @rchatter, @SohamBhattacharya, @argiro, @Martin-Grunewald, @missirol, @ReyerBand this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@rovere
Copy link
Contributor Author

rovere commented Mar 23, 2024

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-188262/38360/summary.html
COMMIT: 37b2ad4
CMSSW: CMSSW_14_1_X_2024-03-22-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44523/38360/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 48 lines to the logs
  • Reco comparison results: 50 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3297537
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3297514
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 5 / 46 workflows

@Martin-Grunewald
Copy link
Contributor

Martin-Grunewald commented Mar 25, 2024

It is our convention that at HLT, module labels start with lower case hlt and sequences start with uper case HLT.

c.f
Remove hltEcalUncalibRecHit module as a duplicate of ecalMultiFitUncalibRecHit

@rovere
Copy link
Contributor Author

rovere commented Mar 25, 2024

Ciao @ Martin-Grunewald You mention that already in my last PR.
Currently, I count 116 modules (and 41 sequences) in the Phase2 menu that do not follow this convention.

Would it make sense to have a dedicated PR to address this issue?

@Martin-Grunewald
Copy link
Contributor

Sure - it does not have to be this PR.

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants